-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add YAKD - Kubernetes Dashboard addon #17775
Conversation
Welcome @manusa! |
Hi @manusa. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add an addon for automatically setting up [YAKD (Yet Another Kubernetes Dashboard)](https://github.com/manusa/yakd) This is an alternative Kubernetes Dashboard with special support for Minikube, OpenShift, and other flavors of Kubernetes. It was originally started as an example project for [YAKC (Yet Another Kubernetes Client)](https://github.com/manusa/yakc) but it was recently spun off as a separate project. Regarding Minikube, it offers specific functionality such as cluster detection, support for opening NodePort services from the interface, and more.
6528242
to
0078ccd
Compare
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you're only building your image for amd64, would it be possible to also build it for arm64?
site/content/en/docs/handbook/addons/yakd-kubernetes-dashboard.md
Outdated
Show resolved
Hide resolved
Hey Steven, |
/ok-to-test |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other then typo this it looks good
minikube service yakd-dashboard -n yakd-dashboard | ||
``` | ||
|
||
There dashboard will open in a new browser window and you should be able to start using it with no further hassle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There dashboard will open in a new browser window and you should be able to start using it with no further hassle. | |
The dashboard will open in a new browser window and you should be able to start using it with no further hassle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thx!
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
e33a2cc
to
1bdbc58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: manusa, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kvm2 driver with docker runtime
Times for minikube ingress: 27.6s 23.6s 27.1s 27.1s 27.5s Times for minikube start: 52.1s 51.1s 50.9s 50.6s 49.0s docker driver with docker runtime
Times for minikube (PR 17775) start: 24.6s 24.8s 21.6s 21.2s 22.4s Times for minikube ingress: 20.8s 17.9s 20.8s 19.4s 20.8s docker driver with containerd runtime
Times for minikube start: 20.2s 20.8s 23.3s 21.5s 22.7s Times for minikube ingress: 31.3s 46.3s 31.3s 31.3s 31.3s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
This PR adds an addon for automatically setting up YAKD (Yet Another Kubernetes Dashboard).
This is an alternative Kubernetes Dashboard with special support for Minikube, OpenShift, and other flavors of Kubernetes.
It was originally started as an example project for YAKC (Yet Another Kubernetes Client) but it was recently spun off as a separate project.
Regarding Minikube, it offers specific functionality such as cluster detection, support for opening
NodePort
services from the interface, and more.